Details

      Description

      Sometimes instead of using simple if-then clause, chunks of jsps are being just copy-pasted twice. So get rid of these duplicative parts

      Examples:
      lams_tool_laqa/web/learning/LearnerRep.jsp
      lams_tool_laqa/web/monitoring/AllSessionsSummary.jsp

      lams_tool_lamc/web/learning/IndividualLearnerResults.jsp

      lams_tool_vote/web/monitoring/AllSessionsSummary.jsp


      Preferably to improve Java code as well. But this is probably too good to become true ;)

        Activity

        Hide
        dronych Andrey Balan added a comment -
        lams_tool_laqa/web//learning/LearnerRep.jsp and lams_tool_laqa/web/learning/RevisitedLearnerRep.jsp are now without duplicative parts (done as part of LDEV-2908)
        Show
        dronych Andrey Balan added a comment - lams_tool_laqa/web//learning/LearnerRep.jsp and lams_tool_laqa/web/learning/RevisitedLearnerRep.jsp are now without duplicative parts (done as part of LDEV-2908 )
        Hide
        dronych Andrey Balan added a comment -
        All duplicative jsp parts were removed but I'll probably leave this JIRA open to commit under it some further code refactoring
        Show
        dronych Andrey Balan added a comment - All duplicative jsp parts were removed but I'll probably leave this JIRA open to commit under it some further code refactoring
        Hide
        dronych Andrey Balan added a comment -
        Get rid of lams_tool_lamc/web/learning/viewAnswers.jsp as it shows the same information as IndividualLearnerResults.jsp. Just keep all required buttons (like notebook ones) from viewAnswers.jsp
        Show
        dronych Andrey Balan added a comment - Get rid of lams_tool_lamc/web/learning/viewAnswers.jsp as it shows the same information as IndividualLearnerResults.jsp. Just keep all required buttons (like notebook ones) from viewAnswers.jsp
        Hide
        dronych Andrey Balan added a comment -
        Get rid of either lams_tool_laqa/web/learning/LearnerRep.jsp or lams_tool_laqa/web/learning/RevisitiedLearnerRep.jsp
        Show
        dronych Andrey Balan added a comment - Get rid of either lams_tool_laqa/web/learning/LearnerRep.jsp or lams_tool_laqa/web/learning/RevisitiedLearnerRep.jsp
        Hide
        ernieg Ernie Ghiglione added a comment -
        Good news here is that Sanjana has been working on the Voting part of this (see LDEV-3983)
        Show
        ernieg Ernie Ghiglione added a comment - Good news here is that Sanjana has been working on the Voting part of this (see LDEV-3983 )
        Hide
        dronych Andrey Balan added a comment -
        There are a few MCQ Authoring validation issues:
        * Edit existing question. Add 2 empty options, after this you can delete existing ones which will lead to zero options and exception throwing later on
        * Start creating a new question. Enter text to only correct option. You'll be able to save such question with only one candidate
        * Modify options (for instance, move up or down any of them). Press cancel button. Reopen question and you'll see that canceled changes are still there
        * In case of duplicate questions (i.e. having identical question text) it will skip adding such questions with no warning whatsoever. Add a client side validation or an error warning after returning from the server side.
        Show
        dronych Andrey Balan added a comment - There are a few MCQ Authoring validation issues: * Edit existing question. Add 2 empty options, after this you can delete existing ones which will lead to zero options and exception throwing later on * Start creating a new question. Enter text to only correct option. You'll be able to save such question with only one candidate * Modify options (for instance, move up or down any of them). Press cancel button. Reopen question and you'll see that canceled changes are still there * In case of duplicate questions (i.e. having identical question text) it will skip adding such questions with no warning whatsoever. Add a client side validation or an error warning after returning from the server side.
        Hide
        ernieg Ernie Ghiglione added a comment -
        Moving to 3.2
        Show
        ernieg Ernie Ghiglione added a comment - Moving to 3.2

          People

          • Assignee:
            dronych Andrey Balan
            Reporter:
            dronych Andrey Balan
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development