Uploaded image for project: 'LAMS Development'
  1. LAMS Development
  2. LDEV-2834

IE9 doesn't open pop-up to review previously completed activities

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Learner
    • Labels:
      None
    • Environment:
      IE9

      Description

      When using the Flash progress bar to review previously completed activities, double clicking on the activities won't open the popup.

      One of the things I noticed though is that if you double click on an activity that you haven't reached the appropriate "You haven't reached this activity" message show. So this means that flash is detecting double clicks properly.

      Could this be a javascript issue?

        Activity

        ernieg Ernie Ghiglione created issue -
        Hide
        ernieg Ernie Ghiglione added a comment -
        Hi Andrey, I think I might have a lead into this issue.

        It seems that IE9 deprecates the VBscript client support that IE used to have. And it seems that the code we use to open the pop-ups in IE, we make use of this code see (lams_learning/web/mainflash.jsp):

        ...
        var thePopUp = null;

        var isInternetExplorer = navigator.appName.indexOf("Microsoft") != -1;
        function learning_DoFSCommand(command, args) {
        //alert("command:"+command+","+args);
        if (command == "alert") {
        doAlert(args);
        }else if (command == "openPopUp"){
        openPopUpFS(args);
        }else if (command == "closeWindow"){
        closeWindow(args);
        }
        }

        // Hook for Internet Explorer.
        if (navigator.appName && navigator.appName.indexOf("Microsoft") != -1 && navigator.userAgent.indexOf("Windows") != -1 && navigator.userAgent.indexOf("Windows 3.1") == -1) {
        document.write('<script language=\"VBScript\"\>\n');
        document.write('On Error Resume Next\n');
        document.write('Sub learning_FSCommand(ByVal command, ByVal args)\n');
        document.write(' Call learning_DoFSCommand(command, args)\n');
        document.write('End Sub\n');
        document.write('</script\>\n');
        }


        So most likely, we can use plain javascript for opening the popups now as these are supported since IE7 onwards.

        The fix shouldn't be too bad (I think)
        Show
        ernieg Ernie Ghiglione added a comment - Hi Andrey, I think I might have a lead into this issue. It seems that IE9 deprecates the VBscript client support that IE used to have. And it seems that the code we use to open the pop-ups in IE, we make use of this code see (lams_learning/web/mainflash.jsp): ... var thePopUp = null; var isInternetExplorer = navigator.appName.indexOf("Microsoft") != -1; function learning_DoFSCommand(command, args) { //alert("command:"+command+","+args); if (command == "alert") { doAlert(args); }else if (command == "openPopUp"){ openPopUpFS(args); }else if (command == "closeWindow"){ closeWindow(args); } } // Hook for Internet Explorer. if (navigator.appName && navigator.appName.indexOf("Microsoft") != -1 && navigator.userAgent.indexOf("Windows") != -1 && navigator.userAgent.indexOf("Windows 3.1") == -1) { document.write('<script language=\"VBScript\"\>\n'); document.write('On Error Resume Next\n'); document.write('Sub learning_FSCommand(ByVal command, ByVal args)\n'); document.write(' Call learning_DoFSCommand(command, args)\n'); document.write('End Sub\n'); document.write('</script\>\n'); } So most likely, we can use plain javascript for opening the popups now as these are supported since IE7 onwards. The fix shouldn't be too bad (I think)
        Hide
        ernieg Ernie Ghiglione added a comment -
        BTW, there's another jsp: controlFrame.jsp which has the *same* javascript code as mainflash.jsp (redundant?).

        Please have a look if it's possible to extract a .js file that both of these files can use instead?
        Show
        ernieg Ernie Ghiglione added a comment - BTW, there's another jsp: controlFrame.jsp which has the *same* javascript code as mainflash.jsp (redundant?). Please have a look if it's possible to extract a .js file that both of these files can use instead?
        Hide
        dronych Andrey Balan added a comment -
        done
        Show
        dronych Andrey Balan added a comment - done
        dronych Andrey Balan made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        dronych Andrey Balan added a comment -
        Out of the sudden IE stopped opening previously completed activities.
        Additionally, neither Exit nor Export buttons work.
        Show
        dronych Andrey Balan added a comment - Out of the sudden IE stopped opening previously completed activities. Additionally, neither Exit nor Export buttons work.
        dronych Andrey Balan made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        dronych Andrey Balan added a comment -
        done
        Show
        dronych Andrey Balan added a comment - done
        dronych Andrey Balan made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        ernieg Ernie Ghiglione added a comment -
        Tested and closed
        Show
        ernieg Ernie Ghiglione added a comment - Tested and closed
        ernieg Ernie Ghiglione made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            dronych Andrey Balan
            Reporter:
            ernieg Ernie Ghiglione
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development