Uploaded image for project: 'LAMS Development'
  1. LAMS Development
  2. LDEV-2826

Remove page breaks existing links and caused null pointer exception

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Tool Wiki
    • Labels:
      None

      Description

      Daniel Schneider has brought this issue up in the LAMS Community (http://lamscommunity.org/dotlrn/clubs/technicalcommunity/forums/message-view?message_id=1364836)

      The main problem here is when we remove pages from the Wiki, we should review the links to the pages we removing and get rid of the hrefs as otherwise when you click on a link of a missing page you get the attached exception.

      So to fix this, I think what we should do is to tag the page as removed but not actually remove it (as there's another feature that was suggested to unremove pages). This way, we don't need to remove links to the removed pages but when the removed page is loaded, we put a clear message at the top that this page has been removed.

        Activity

        ernieg Ernie Ghiglione created issue -
        ernieg Ernie Ghiglione made changes -
        Field Original Value New Value
        Attachment Picture 1.png [ 12165 ]
        Hide
        ernieg Ernie Ghiglione added a comment -
        Note that after a page has been tagged as removed, it can not be edited (see LDEV-2827 pic as an example)
        Show
        ernieg Ernie Ghiglione added a comment - Note that after a page has been tagged as removed, it can not be edited (see LDEV-2827 pic as an example)
        Hide
        marcin Marcin Cieslak added a comment -
        When authoring a new design, teacher can still remove a Wiki page for real. Otherwise if author made a mistake, he would be unable to delete the unwanted Wiki page and would have to either start filling activity content from a scratch or leave the rubbish page existing.
        When a page is removed for real, content of other pages from the same Wiki is checked for references to the missing page. Such references are replaced with a link to the same page, i.e. href="#", so clicking them will not trigger an exception.

        Once the activity is used in lesson, Learner and Monitors can only mark the page as removed instead of removing it for real.

        Another task (LDEV-2827) allows unremoving pages.

        Some other minor issues with Wiki Tool were fixed.
        Show
        marcin Marcin Cieslak added a comment - When authoring a new design, teacher can still remove a Wiki page for real. Otherwise if author made a mistake, he would be unable to delete the unwanted Wiki page and would have to either start filling activity content from a scratch or leave the rubbish page existing. When a page is removed for real, content of other pages from the same Wiki is checked for references to the missing page. Such references are replaced with a link to the same page, i.e. href="#", so clicking them will not trigger an exception. Once the activity is used in lesson, Learner and Monitors can only mark the page as removed instead of removing it for real. Another task ( LDEV-2827 ) allows unremoving pages. Some other minor issues with Wiki Tool were fixed.
        marcin Marcin Cieslak made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        ernieg Ernie Ghiglione added a comment -
        You are very right... authors must delete pages in case they do a mistake.

        Tested and closed now
        Show
        ernieg Ernie Ghiglione added a comment - You are very right... authors must delete pages in case they do a mistake. Tested and closed now
        ernieg Ernie Ghiglione made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            marcin Marcin Cieslak
            Reporter:
            ernieg Ernie Ghiglione
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development