Uploaded image for project: 'LAMS Development'
  1. LAMS Development
  2. LDEV-2806

Upgrade 2.3.5 -> 2.4: produces serious issues with learner's progress

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: General
    • Labels:
      None

      Description

      The problem:

      When upgrading to 2.4 from a 2.3.5 server, incomplete sequences for learners start to progress very strangely.

      After the 2.4 upgrade, when a learner attempts to continue a lesson that he left incompleted in 2.3.5, then as soon as he completes an activity, the progress bar sends the user to the end of the lessons and completes it. However, all the activities in the middle, from the current to the end of the lesson are incompleted and don't even attempted. Also, the learner can't get to the missing activities as there's the progress bar tells him that he hasn't reached them!

      So this is a big problem.

      To reproduce, please use the attached db dump (which is from 2.3.5) after import, start jboss5 normally and login as say "test3" passwd: "sysadmin". Then go into the Antartica lesson, complete an activity and bang... you have completed the lesson

      Please give this a priority as we have recently upgraded lamsv2 to 2.4 and this will become a big issue if not resolved shortly.

        Activity

        Hide
        ernieg Ernie Ghiglione added a comment -
        Here's what you get in the logs once you click on the next activity:


        2012-02-19 12:17:23,860 DEBUG [LearnerService] CompleteToolSession() for tool session id 55 learnerId 6 url is http://50.23.80.99:8080/lams/learning/CompleteActivity.do?activityID=176&progressID=12
        2012-02-19 12:17:24,383 DEBUG [LearningWebUtil] Entering activity: progress summary is attempted=&completed=177_176_180&current=
        2012-02-19 12:17:25,071 DEBUG [LearningWebUtil] getLearnerProgress: found progress via progress id
        2012-02-19 12:17:25,071 DEBUG [LearningWebUtil] Entering activity: progress summary is attempted=&completed=177_176_180&current=


        See the blank parameter attempted= and current=

        Show
        ernieg Ernie Ghiglione added a comment - Here's what you get in the logs once you click on the next activity: 2012-02-19 12:17:23,860 DEBUG [LearnerService] CompleteToolSession() for tool session id 55 learnerId 6 url is http://50.23.80.99:8080/lams/learning/CompleteActivity.do?activityID=176&progressID=12 2012-02-19 12:17:24,383 DEBUG [LearningWebUtil] Entering activity: progress summary is attempted=&completed=177_176_180&current= 2012-02-19 12:17:25,071 DEBUG [LearningWebUtil] getLearnerProgress: found progress via progress id 2012-02-19 12:17:25,071 DEBUG [LearningWebUtil] Entering activity: progress summary is attempted=&completed=177_176_180&current= See the blank parameter attempted= and current=
        Hide
        marcin Marcin Cieslak added a comment -
        Blank "attempted" and "current" parameters are normal when user reaches end of a lesson. They simply indicate end of progress and appear even when LAMS behaves correctly.

        The real source of the problem are changes to Activity table structure done for LDEV-2374. Transitions to and from activity are not taken from lams_learning_transition table anymore, but from columns in lams_learning_activity. These columns were not filled with needed data when upgrading to LAMS 2.4.

        A patch was added that fill Activity table with transition data.
        Show
        marcin Marcin Cieslak added a comment - Blank "attempted" and "current" parameters are normal when user reaches end of a lesson. They simply indicate end of progress and appear even when LAMS behaves correctly. The real source of the problem are changes to Activity table structure done for LDEV-2374 . Transitions to and from activity are not taken from lams_learning_transition table anymore, but from columns in lams_learning_activity. These columns were not filled with needed data when upgrading to LAMS 2.4. A patch was added that fill Activity table with transition data.
        Hide
        ernieg Ernie Ghiglione added a comment -
        I think there's a problem with the file you committed as it has 0 lines :-)
        Show
        ernieg Ernie Ghiglione added a comment - I think there's a problem with the file you committed as it has 0 lines :-)
        Hide
        marcin Marcin Cieslak added a comment -
        Patch was committed with proper content. It is Atlassian which incorrectly shows 0 lines of content and difference with previous versions.

        Also, an additional security measure has been added to SQL statement.
        Show
        marcin Marcin Cieslak added a comment - Patch was committed with proper content. It is Atlassian which incorrectly shows 0 lines of content and difference with previous versions. Also, an additional security measure has been added to SQL statement.
        Hide
        ernieg Ernie Ghiglione added a comment -
        Actually, this does work for the Antartica lesson, but if you try the Assessment one (right below Antartica), you will see that you are being sent to the end of the lesson and completes the show. Any ideas?
        Show
        ernieg Ernie Ghiglione added a comment - Actually, this does work for the Antartica lesson, but if you try the Assessment one (right below Antartica), you will see that you are being sent to the end of the lesson and completes the show. Any ideas?
        Hide
        ernieg Ernie Ghiglione added a comment -
        Thanks Marcin. This has done it.
        Show
        ernieg Ernie Ghiglione added a comment - Thanks Marcin. This has done it.

          People

          • Assignee:
            marcin Marcin Cieslak
            Reporter:
            ernieg Ernie Ghiglione
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development