Uploaded image for project: 'LAMS Development'
  1. LAMS Development
  2. LDEV-2796

Change the way news.html gets imported into login.jsp

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: General
    • Labels:
      None

      Description

      Currently there's a catch with the way we import/include the news.html into the login.jsp

      Because we use the tag import rather than include, the tag makes an http call to the server in order to import the page!

      So this is *very* inefficient.

      Also this has stupid implications for clustering... as when LAMS calls itself to get the news.html page it creates a new jboss session in the other node... which is rather silly.

      I believe the reason we didn't use the include tag because we can't use it if the file we are trying to include is outside the .war (and news.html is in lams-www.war -whereas login.jsp in in lams-central.war).

      So I don't think we have many options... we probably need to move this to lams-central instead and also move the new public folder to store the images into lams-central.

      Unless, you think there's other way to do this?

        Activity

        Hide
        marcin Marcin Cieslak added a comment -
        It is true - we can't get JSP from outside current application context using "include" neither tag nor directive.
        We either move news page to lams-central or stick to "import" tag.

        Last commit seems to help a little, though. When observing content requested when loading login.jsp page, I can't seen need for news.html anywhere, but it is displayed correctly.
        Please check if it helps with clustering as well.
        Show
        marcin Marcin Cieslak added a comment - It is true - we can't get JSP from outside current application context using "include" neither tag nor directive. We either move news page to lams-central or stick to "import" tag. Last commit seems to help a little, though. When observing content requested when loading login.jsp page, I can't seen need for news.html anywhere, but it is displayed correctly. Please check if it helps with clustering as well.
        Hide
        ernieg Ernie Ghiglione added a comment -
        Marcin,

        I think we are good now with the new context change as there's no http call to get the news.html page. So I'm resolving this one

        Thanks!
        Show
        ernieg Ernie Ghiglione added a comment - Marcin, I think we are good now with the new context change as there's no http call to get the news.html page. So I'm resolving this one Thanks!

          People

          • Assignee:
            marcin Marcin Cieslak
            Reporter:
            ernieg Ernie Ghiglione
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development