Uploaded image for project: 'LAMS Development'
  1. LAMS Development
  2. LDEV-2507

If IM enabled, a button to jump into it from Monitor is required

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.4
    • Fix Version/s: 2.4, 2.3.5
    • Component/s: Monitor
    • Labels:
      None

      Description

      In the new monitor for 2.4, we need to make sure that the teacher can jump to IM directly from monitor if IM is enabled.

        Activity

        Hide
        ernieg Ernie Ghiglione added a comment -
        I think there's an issue here as the Monitor IM cannot see the learner and the learner cant see the teacher either. Perhaps they are in two separate groups? (see Picture2)
        Show
        ernieg Ernie Ghiglione added a comment - I think there's an issue here as the Monitor IM cannot see the learner and the learner cant see the teacher either. Perhaps they are in two separate groups? (see Picture2)
        Hide
        mseaton Mitchell Seaton (Inactive) added a comment -
        Reason is to do with the chat room's not being the same.
        Chat room is comprised of lesson ID and startDateTime. Issue with this been sent through request parameters and formats that come through - normal learner popup gets value from Action class where from Monitor we have the value coming through Flash (Date class). The string formats end up being different, also trying to use getTime() function on both results in a different integer value so cannot be used.

        Need to consider what the requirements are for the Chat room name? Is start date time required to be part of room name string? Lesson ID is a unique ID - is the date there for a security measure?

        The sent parameter createStartDate str from Flash can be constructed to the correct format - and can even be paired to a custom format, it's just a bit 'flimsy', so want to confirm about the room name before going ahead and making the changes.
        Show
        mseaton Mitchell Seaton (Inactive) added a comment - Reason is to do with the chat room's not being the same. Chat room is comprised of lesson ID and startDateTime. Issue with this been sent through request parameters and formats that come through - normal learner popup gets value from Action class where from Monitor we have the value coming through Flash (Date class). The string formats end up being different, also trying to use getTime() function on both results in a different integer value so cannot be used. Need to consider what the requirements are for the Chat room name? Is start date time required to be part of room name string? Lesson ID is a unique ID - is the date there for a security measure? The sent parameter createStartDate str from Flash can be constructed to the correct format - and can even be paired to a custom format, it's just a bit 'flimsy', so want to confirm about the room name before going ahead and making the changes.
        Hide
        ernieg Ernie Ghiglione added a comment -
        Would it be possible to make a call to get the chatroom (lessonID+ startDateTime) from the back end instead?
        Show
        ernieg Ernie Ghiglione added a comment - Would it be possible to make a call to get the chatroom (lessonID+ startDateTime) from the back end instead?
        Hide
        mseaton Mitchell Seaton (Inactive) added a comment -
        No, see presenceChat.jsp - the room is created there which is included in the learner or im jsp(s). Room name variable is created at that top level (javascript).
        Show
        mseaton Mitchell Seaton (Inactive) added a comment - No, see presenceChat.jsp - the room is created there which is included in the learner or im jsp(s). Room name variable is created at that top level (javascript).
        Hide
        mseaton Mitchell Seaton (Inactive) added a comment -
        Changes checked in - http://lamscvs.melcoe.mq.edu.au/fisheye/changelog/lams/?cs=lams2_3_release:mseaton:20100415141420
        However, noticing some issue using FF 3.6.* and Chrome with the Mary Morgan user, once having opened the IM (only) window - doesn't appear to be entering a room.
        Show
        mseaton Mitchell Seaton (Inactive) added a comment - Changes checked in - http://lamscvs.melcoe.mq.edu.au/fisheye/changelog/lams/?cs=lams2_3_release:mseaton:20100415141420 However, noticing some issue using FF 3.6.* and Chrome with the Mary Morgan user, once having opened the IM (only) window - doesn't appear to be entering a room.
        Hide
        mseaton Mitchell Seaton (Inactive) added a comment -
        Still issue with IE (javascript error) on IM window opened from Monitor to resolve.
        Show
        mseaton Mitchell Seaton (Inactive) added a comment - Still issue with IE (javascript error) on IM window opened from Monitor to resolve.
        Hide
        mseaton Mitchell Seaton (Inactive) added a comment -
        Made some updates to presence include files (.js/.jsp) to handle additional url parameter presenceShown for having the IM open on load.
        Show
        mseaton Mitchell Seaton (Inactive) added a comment - Made some updates to presence include files (.js/.jsp) to handle additional url parameter presenceShown for having the IM open on load.
        Hide
        ernieg Ernie Ghiglione added a comment -
        Tested and closed for 2.3.5 and 2.4
        Show
        ernieg Ernie Ghiglione added a comment - Tested and closed for 2.3.5 and 2.4
        Hide
        ernieg Ernie Ghiglione added a comment -
        Reopen as the status in JIRA shows as resolved instead of Close... re-closing in just a sec
        Show
        ernieg Ernie Ghiglione added a comment - Reopen as the status in JIRA shows as resolved instead of Close... re-closing in just a sec

          People

          • Assignee:
            ernieg Ernie Ghiglione
            Reporter:
            ernieg Ernie Ghiglione
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development