Uploaded image for project: 'LAMS Development'
  1. LAMS Development
  2. LDEV-2486

If user hasnt started lesson, can get null pointer in LearnerService.getProgressDTOByLessonId

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.3
    • Fix Version/s: 2.4, 2.3.4
    • Component/s: None
    • Labels:
      None

      Description

      Noticed by Chen Rui at NTU,

      A call is made to get the learner progress a null pointer will be thrown if there is no data to get.

      public LearnerProgressDTO getProgressDTOByLessonId(Long lessonId, Integer learnerId) {
      return learnerProgressDAO.getLearnerProgressByLearner(learnerId, lessonId).getLearnerProgressData();
      }

      A null check should be done here

        Activity

        Hide
        lfoxton Luke Foxton added a comment -
        Done
        Show
        lfoxton Luke Foxton added a comment - Done

          People

          • Assignee:
            lfoxton Luke Foxton
            Reporter:
            lfoxton Luke Foxton
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development