Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4, 2.3.4
    • Component/s: General
    • Labels:
      None

      Description


      It seems that the changing the Default HTML Theme in LAMS is not really working. In the configuration settings in Sysadmin, you are able to specify a "Default HTML Theme". However, there are some problems with this.

      1) It seems that in some places we have the hard coded the CSS files. After changing the default HTML theme, the index.do still points to the defaultMainHTML.css file and no mention of the new css:

      <link href="http://172.20.100.18:8080/lams/css/defaultMainHTML.css" rel="stylesheet" type="text/css">

      and learner pages have:

      <link href="http://172.20.100.18:8080/lams/css/defaultHTML_learner.css" rel="stylesheet" type="text/css">

      and no mentioned to the <newCssName>_learner.css


      In addition, and given the changes we've done for 2.3, it sees that the login page uses defaultHTML.css and index.do uses defaultMainHTML.css. So we added a new css file but I don't think that's taken into account when changing the default HTML theme.

      So here's what we need to do:

      Fix the default HTML Theme so when it changes in Sysdamin all pages index.do, learner pages, login page, etc... change according to the new CSS theme. This will probably mean that we need themes to provide three .css files:

      * <name>MainHTML.css
      * <name>HTML.css
      * <name>HTML_learner.css

      And of course all 3 (all of the above files)_rtl.css (if these are provided).



        Activity

        Hide
        ernieg Ernie Ghiglione added a comment -
        Tested and closed
        Show
        ernieg Ernie Ghiglione added a comment - Tested and closed
        Hide
        ernieg Ernie Ghiglione added a comment -
        Perfect.

        Only one small thing:

        I think in the drop down menu in My profile, we should use the description field rather than the name... as we use the name for the actual name of the css file.

        Show
        ernieg Ernie Ghiglione added a comment - Perfect. Only one small thing: I think in the drop down menu in My profile, we should use the description field rather than the name... as we use the name for the actual name of the css file.
        Hide
        lfoxton Luke Foxton added a comment -
        All done finally

        You can
        install new themes
        set default theme in theme management page
        change your theme in my profile
        choose the theme when adding new users
        change a users theme when editing the user

        Also the wiki page for themes has been updated to comply with the changes
        Show
        lfoxton Luke Foxton added a comment - All done finally You can install new themes set default theme in theme management page change your theme in my profile choose the theme when adding new users change a users theme when editing the user Also the wiki page for themes has been updated to comply with the changes
        Hide
        lfoxton Luke Foxton added a comment -
        TODO:

        * Remove and rename defunct tables:

        lams_css_theme_ve -> rename to lams_theme and remove unneccessary columns
        lams_css_property -> remove
        lams_css_style -> remove

        * Add an isFlash column to the lams_theme table

        * Update the wiki page to comply with the changes http://wiki.lamsfoundation.org/display/lams/LAMS+Themes+or+Skins

        Show
        lfoxton Luke Foxton added a comment - TODO: * Remove and rename defunct tables: lams_css_theme_ve -> rename to lams_theme and remove unneccessary columns lams_css_property -> remove lams_css_style -> remove * Add an isFlash column to the lams_theme table * Update the wiki page to comply with the changes http://wiki.lamsfoundation.org/display/lams/LAMS+Themes+or+Skins
        Hide
        lfoxton Luke Foxton added a comment -
        Need to add in functionality so sysadmins can install themes
        Show
        lfoxton Luke Foxton added a comment - Need to add in functionality so sysadmins can install themes
        Hide
        lfoxton Luke Foxton added a comment -
        Resolving this issue - this will require lots of testing over the coming months
        Show
        lfoxton Luke Foxton added a comment - Resolving this issue - this will require lots of testing over the coming months

          People

          • Assignee:
            lfoxton Luke Foxton
            Reporter:
            ernieg Ernie Ghiglione
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development