Uploaded image for project: 'LAMS Development'
  1. LAMS Development
  2. LDEV-2396

Exception being thrown in DimDim tool (Server version not defined)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.3.4
    • Fix Version/s: 2.4, 2.3.5
    • Component/s: Tool DimDim
    • Labels:
      None

      Description

      Check out DimDim tool.
      Do *not* modify any default db settings.
      Create Dim Dim tool in authoring
      Then start a lesson with it and you'll get the following exception:

      org.lamsfoundation.lams.tool.dimdim.util.DimdimException: Server version not defined
      at org.lamsfoundation.lams.tool.dimdim.web.actions.LearningAction.unspecified(LearningAction.java:321)


        Activity

        Hide
        dronych Andrey Balan added a comment -
        Ernie,

        the version of the server is not being set by default
        (http://lamscvs.melcoe.mq.edu.au:8060/fisheye/browse/lams/lams_tool_dimdim/db/sql/create_lams_tool_dimdim.sql?r=1.10)

        but we check it in LearningAction
        (http://lamscvs.melcoe.mq.edu.au:8060/fisheye/browse/lams/lams_tool_dimdim/src/java/org/lamsfoundation/lams/tool/dimdim/web/actions/LearningAction.java?r1=1.14&r2=1.15
        line 332)


        and so if I haven't set it in admin page then in learning I'll get an exception.
        which is to my mind not 100% correct

        I would probably suggest setting the version by default (simply modify create_lams_tool_dimdim.sql) or skip checking it in learning.


        so what would you say?
        Show
        dronych Andrey Balan added a comment - Ernie, the version of the server is not being set by default ( http://lamscvs.melcoe.mq.edu.au:8060/fisheye/browse/lams/lams_tool_dimdim/db/sql/create_lams_tool_dimdim.sql?r=1.10 ) but we check it in LearningAction ( http://lamscvs.melcoe.mq.edu.au:8060/fisheye/browse/lams/lams_tool_dimdim/src/java/org/lamsfoundation/lams/tool/dimdim/web/actions/LearningAction.java?r1=1.14&r2=1.15 line 332) and so if I haven't set it in admin page then in learning I'll get an exception. which is to my mind not 100% correct I would probably suggest setting the version by default (simply modify create_lams_tool_dimdim.sql) or skip checking it in learning. so what would you say?
        Hide
        ernieg Ernie Ghiglione added a comment -
        Andrey, I think it's best to stop checking on learning as we don't need to differenciate between the versions any more.

        Thanks!
        Show
        ernieg Ernie Ghiglione added a comment - Andrey, I think it's best to stop checking on learning as we don't need to differenciate between the versions any more. Thanks!
        Hide
        dronych Andrey Balan added a comment -
        Ok, I removed version check in learning. and it works all good there


        but there is another possible bug in monitoring:
        if you go to monitor and try to start the conference then you'll get the same kind of error (it just checks for the version again).

        therefore may be we should forbid teacher to start conference before the version is set in admin.
        along with this providing him with the information why he is not allowed to start the conference.
        we could use <div class="info> or a popup with information on this.

        what do you think?
        Show
        dronych Andrey Balan added a comment - Ok, I removed version check in learning. and it works all good there but there is another possible bug in monitoring: if you go to monitor and try to start the conference then you'll get the same kind of error (it just checks for the version again). therefore may be we should forbid teacher to start conference before the version is set in admin. along with this providing him with the information why he is not allowed to start the conference. we could use <div class="info> or a popup with information on this. what do you think?
        Hide
        ernieg Ernie Ghiglione added a comment -
        I think the version stuff is some left over thing from a previous implementation that distinguished between the open source version of Dimdim and their enterprise version. However, the latest open source version now uses the exact same API, so no need to change this. However, Antonio must have left all this version stuff accidentally.

        In monitor, we should also get rid of the version check as it doesn't do much now. The teacher does have to start the conference from monitor though.
        Show
        ernieg Ernie Ghiglione added a comment - I think the version stuff is some left over thing from a previous implementation that distinguished between the open source version of Dimdim and their enterprise version. However, the latest open source version now uses the exact same API, so no need to change this. However, Antonio must have left all this version stuff accidentally. In monitor, we should also get rid of the version check as it doesn't do much now. The teacher does have to start the conference from monitor though.
        Hide
        dronych Andrey Balan added a comment -
        Ernie,
        can you please test this tool on a real dimdim server
        as you probably know one appropriate for this


        it will also answer the question if I picked up the correct method for url constuction
        (http://lamscvs.melcoe.mq.edu.au:8060/fisheye/browse/lams/lams_tool_dimdim/src/java/org/lamsfoundation/lams/tool/dimdim/service/DimdimService.java?r=1.18
        line 484)
        Show
        dronych Andrey Balan added a comment - Ernie, can you please test this tool on a real dimdim server as you probably know one appropriate for this it will also answer the question if I picked up the correct method for url constuction ( http://lamscvs.melcoe.mq.edu.au:8060/fisheye/browse/lams/lams_tool_dimdim/src/java/org/lamsfoundation/lams/tool/dimdim/service/DimdimService.java?r=1.18 line 484)
        Hide
        dronych Andrey Balan added a comment -
        it also affects 2.3.4 version
        Show
        dronych Andrey Balan added a comment - it also affects 2.3.4 version
        Hide
        ernieg Ernie Ghiglione added a comment -
        tool deprecated
        Show
        ernieg Ernie Ghiglione added a comment - tool deprecated

          People

          • Assignee:
            ernieg Ernie Ghiglione
            Reporter:
            dronych Andrey Balan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development