Uploaded image for project: 'LAMS Development'
  1. LAMS Development
  2. LDEV-2346

Small window caused images tool to be a little munged

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.4, 2.3.2
    • Component/s: Tool Image Gallery
    • Labels:
      None

      Description

      If you open a normal learner window (unexpanded) the screen becomes a bit munged. This can be fixed by setting a custom css option for the content div so its minimum width adjusts to fit the image.

      Or perhaps the image itself should resize to fit into the space provided

        Activity

        Hide
        dronych Andrey Balan added a comment -
        Hey Luke,

        I have a question why is the learning screen (on this screenshot) so small?
        We set learner screen size to 1024*768 by default (in insert_lams_windows_config_data.sql).
        and if 1024*768 is used everything fits just perfect.


        But if you need to decrease this parameter (set the smaller size)
        Then you can change the size of the image and thumbnails in tool's admin page.
        Then image gallery tool will resize images using specific algorithm almost without loosing quality.
        resized images are going to be shown on page. Everything fits and problem is solved.


        but in case we let the browser automatically adjust the image size:
        - the quality of the adjusted image will be very poor;
        - thumbnails should be also adjusted automatically which is not a trivial task as we use JS widget there


        so what would you say? if the ability to set image and thumbnail sizes in admin page will be enough and can solve this issue?
        Show
        dronych Andrey Balan added a comment - Hey Luke, I have a question why is the learning screen (on this screenshot) so small? We set learner screen size to 1024*768 by default (in insert_lams_windows_config_data.sql). and if 1024*768 is used everything fits just perfect. But if you need to decrease this parameter (set the smaller size) Then you can change the size of the image and thumbnails in tool's admin page. Then image gallery tool will resize images using specific algorithm almost without loosing quality. resized images are going to be shown on page. Everything fits and problem is solved. but in case we let the browser automatically adjust the image size: - the quality of the adjusted image will be very poor; - thumbnails should be also adjusted automatically which is not a trivial task as we use JS widget there so what would you say? if the ability to set image and thumbnail sizes in admin page will be enough and can solve this issue?
        Hide
        lfoxton Luke Foxton added a comment -
        The learner screen size is configurable by the sysadmin, it can be adjusted to any size... its up to the owner how big he wants the screen to be. This is not something we have control of. Also we cannot adjust this when we update lams as we may be removing the server's custom configs as set up by their system administrator, so the sizes we see on most production servers are the same as the original, unless they were altered specifically by the sysadmin.

        The learner window content areas are always set to resizable, even when the screen is of an optimal size. So this is something that needs to be allowed for in the design of the tool's learner page... It needs to be able to go as small as can be seen on mobile devices in some cases.. As you can see from the screenshot the content area will contract to smaller than the size of the content in it.

        I suppose this may be unavoidable in the case of images, you probably dont want to be resizing images on the fly. But what you can do is set a min-width/miniheight param on a div inside the content div. That way the content div will not contract passed a certain point, and the user can use a scroll bar to see the full size.

        Its a cosmetic issue really, the only real benefit is that the images always appear within the bounds of the white content area.

        Show
        lfoxton Luke Foxton added a comment - The learner screen size is configurable by the sysadmin, it can be adjusted to any size... its up to the owner how big he wants the screen to be. This is not something we have control of. Also we cannot adjust this when we update lams as we may be removing the server's custom configs as set up by their system administrator, so the sizes we see on most production servers are the same as the original, unless they were altered specifically by the sysadmin. The learner window content areas are always set to resizable, even when the screen is of an optimal size. So this is something that needs to be allowed for in the design of the tool's learner page... It needs to be able to go as small as can be seen on mobile devices in some cases.. As you can see from the screenshot the content area will contract to smaller than the size of the content in it. I suppose this may be unavoidable in the case of images, you probably dont want to be resizing images on the fly. But what you can do is set a min-width/miniheight param on a div inside the content div. That way the content div will not contract passed a certain point, and the user can use a scroll bar to see the full size. Its a cosmetic issue really, the only real benefit is that the images always appear within the bounds of the white content area.
        Hide
        dronych Andrey Balan added a comment -
        Good point!
        I like the idea of setting the minimum width param
        I'll try to implement this

        thanks
        Show
        dronych Andrey Balan added a comment - Good point! I like the idea of setting the minimum width param I'll try to implement this thanks
        Hide
        dronych Andrey Balan added a comment -
        done
        Show
        dronych Andrey Balan added a comment - done
        Hide
        ernieg Ernie Ghiglione added a comment -
        Tested and closed
        Show
        ernieg Ernie Ghiglione added a comment - Tested and closed

          People

          • Assignee:
            dronych Andrey Balan
            Reporter:
            lfoxton Luke Foxton
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development