Uploaded image for project: 'LAMS Development'
  1. LAMS Development
  2. LDEV-1126

Close Window message shows in a non-lock on finish, completed chat in chat/scribe

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.4
    • Component/s: Learner
    • Labels:
      None

      Description

      * Create a design with chat/scribe and start a lesson with this design (ie not preview). Make sure the chat is set to NOT lock on finish.
      * Run learner.
      * Complete chat but not scribe.
      * Double click on the heading part of the Chat and Scribe section in the progress bar.
      * The page will be redisplayed in the normal window (ie not a popup)
      * The chat window will redraw as it is set to NOT lock on finish. In Chat, click Finish.
      * Because it is already finished, the "Please Close This Window" message appears in the Chat area. This is misleading - should be the "complete other activity" message.

      Need to change the logic that tests if the activity is already finished. If it is within a parallel activity and the parallel activity isn't finished, then need to display the "complete other activity" message. Rather than doing it off the progress status, can we work it out from the window itself?

        Activity

        Hide
        fionam Fiona Malikoff added a comment -
        Previously the progress engine just detected that the activity was already finished and forwarded to the close screen. The close screen tried to close and couldn't because it was in the frameset.

        Now when the progress engine detects it is a completed activity, it still works out what the next screen should be, and passes that to the close window. If the close window is in the popup window it attempts to close. If it isn't in the popup window, it goes to the next screen.

        So this fixes the problem as described here. But there is still one more problem.

        If you double click on the parallel activity in the progress bar and view it in the popup window, and then click on finish, both windows end up showing "Please close this window" in both windows. See attached screenshot.
        Show
        fionam Fiona Malikoff added a comment - Previously the progress engine just detected that the activity was already finished and forwarded to the close screen. The close screen tried to close and couldn't because it was in the frameset. Now when the progress engine detects it is a completed activity, it still works out what the next screen should be, and passes that to the close window. If the close window is in the popup window it attempts to close. If it isn't in the popup window, it goes to the next screen. So this fixes the problem as described here. But there is still one more problem. If you double click on the parallel activity in the progress bar and view it in the popup window, and then click on finish, both windows end up showing "Please close this window" in both windows. See attached screenshot.
        Hide
        ernieg Ernie Ghiglione added a comment -
        Tested and closed
        Show
        ernieg Ernie Ghiglione added a comment - Tested and closed

          People

          • Assignee:
            ernieg Ernie Ghiglione
            Reporter:
            fionam Fiona Malikoff
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development